Update Social icons snapshots #6141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
geriux
force-pushed
the
update-social-icons-snapshot
branch
from
4a9b159 to
5a10bec
Compare
|
Hey @dcalhoun 👋 I was wondering if you could review this PR. It updates the failing snapshots for the Social Icons visual tests. For Android, it's getting cut off a bit but we can address that when we work on #6140 what do you think? By the way, the failing Builtkite job is due to the existing commit already published. Since this will be merged into the release branch and creating a new commit it shouldn't be an issue. Thanks! |
dcalhoun
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates failing tests due to outdated snapshots
To test:
PR submission checklist: