Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/colors and richtextinputevent #625

Merged
merged 4 commits into from
Feb 20, 2019
Merged

Fix/colors and richtextinputevent #625

merged 4 commits into from
Feb 20, 2019

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Feb 20, 2019

Fixes 2 issues introduced recently:

  1. Error: colors.scss could not be resolved
  2. The renamed UnstableRichTextInputEvent (on the web) that was still RichTextInputEvent on mobile

To test:

  1. Run the demo app. Is should open without any Metro errors
  2. Tap in a rich-text block. It should just work as normal

@hypest hypest mentioned this pull request Feb 20, 2019
Merged
5 tasks
@SergioEstevao SergioEstevao merged commit 8ed6cb1 into develop Feb 20, 2019
@SergioEstevao SergioEstevao deleted the fix/colors-and-richtextinputevent branch February 20, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hypest @SergioEstevao