Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update post title padding #645

Merged
merged 3 commits into from
Feb 22, 2019
Merged

Update post title padding #645

merged 3 commits into from
Feb 22, 2019

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Feb 22, 2019 •
edited
Loading

This PR adds some vertical padding to post title.

gutenberg PR WordPress/gutenberg#14040

To Test:

  • Run metro on this branch
  • Open a post and verify post title has top&bottom paddings

@pinarol pinarol added this to the Beta milestone Feb 22, 2019
@pinarol pinarol self-assigned this Feb 22, 2019
@pinarol pinarol requested a review from koke February 22, 2019 07:53
@pinarol pinarol mentioned this pull request Feb 22, 2019
Merged
5 tasks
etoledom
etoledom approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✅

@hypest hypest modified the milestones: Beta, v1.0 Feb 22, 2019
@pinarol pinarol merged commit f623037 into develop Feb 22, 2019
@pinarol pinarol deleted the fix/post-title-padding branch March 13, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

@koke koke Awaiting requested review from koke

Assignees

@pinarol pinarol

Labels
[OS] Android [OS] iOS
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pinarol @etoledom @hypest