Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image placeholder moves out of its bounds once we tap on it #663

Merged
merged 2 commits into from
Feb 24, 2019
Merged

Image placeholder moves out of its bounds once we tap on it #663

merged 2 commits into from
Feb 24, 2019

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 self-assigned this Feb 22, 2019
@marecar3 marecar3 changed the title mage placeholder moves out of its bounds once we tap on it Image placeholder moves out of its bounds once we tap on it Feb 22, 2019
@SergioEstevao
Copy link
Contributor

I tested this on iOS and now the placeholder no longer moves around over the other blocks when the block is selected.

@hypest hypest added this to the v1.0 milestone Feb 23, 2019
@hypest hypest changed the base branch from develop to release/1.0.1 February 23, 2019 22:50
@hypest
Copy link
Contributor

hypest commented Feb 23, 2019

I moved this PR to target the release/1.0.1 branch, so we include it in the "hotfix" release.

hypest
hypest approved these changes Feb 23, 2019
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Let's update the GB ref to the merged one and we can merge this too!

@hypest hypest modified the milestones: v1.0, v1.0.1 Feb 23, 2019
@hypest hypest merged commit eccb2fe into release/1.0.1 Feb 24, 2019
@hypest hypest deleted the issue/661_Image-placeholder-moves-out-of-its-bounds-once-we-tap-on-it branch February 24, 2019 19:10
@hypest hypest mentioned this pull request Feb 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

@pinarol pinarol Awaiting requested review from pinarol

Assignees

@marecar3 marecar3

Labels
None yet
Projects
None yet
Milestone
v1.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@marecar3 @SergioEstevao @hypest