-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment with i18n caches in CI #6724
base: trunk
Are you sure you want to change the base?
Conversation
7bd057c
to
50a3471
Compare
d7eacdc
to
3ef013f
Compare
Hey @geriux . I started this but then stopped because I wanted to learn more about the cache. Maybe you can answer my question. How does the codebase know about the i18n cache validity? I mean, the only check I've seen in the code is "is the cache in the repo? if not, download" but how is this cache maintained and updated? For the purpose of the automation here, would looking at when Thanks! |
This cache folder only stores the un-optimized translations, there's no mechanism currently to invalidate its content other than manually running When we run the
I think we could rely on the version of the app? If we can pick the version of the |
Updating the localizations is a bit tricky process because it requires analyzing the React Native bundle. The scripts behind the Further information can be found in: p9ugOq-2xq-p2.
Yep, as you pointed out @geriux, we only generate the optimized localizations in releases. Although to be accurate, we run this process when pushing a Git tag, so this would also cover when creating alpha versions. Using an outdated version of localizations in alpha builds shouldn't be an issue, as translations are expected to be included only in final releases. That said, I think relying on the version of the app would work as a way to validate the localizations cache. |
Fixes #
To test:
PR submission checklist: