Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.120.0 #6916

Merged
merged 8 commits into from
Jun 6, 2024
Merged

Release 1.120.0 #6916

merged 8 commits into from
Jun 6, 2024

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Jun 6, 2024 •
edited
Loading

Release for Gutenberg Mobile 1.120.0

Since there's a current breakage in Gutenberg trunk we are branching off from the v1.120.0-alpha1 tag, with changes from 1.119.1

Related PRs

Changes

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

This was referenced Jun 6, 2024
Merged
Merged
@geriux geriux marked this pull request as ready for review June 6, 2024 13:08
geriux
geriux commented Jun 6, 2024
View reviewed changes
package.json
@@ -17,6 +17,7 @@
"@react-native-community/cli": "^12.1.1",
"@typescript-eslint/eslint-plugin": "^6.4.1",
"@wordpress/babel-preset-default": "file:gutenberg/packages/babel-preset-default",
"@wordpress/babel-plugin-import-jsx-pragma": "file:gutenberg/packages/babel-plugin-import-jsx-pragma",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition is related to WordPress/gutenberg#61692 where mobile still uses it.

@SiobhyB SiobhyB self-requested a review June 6, 2024 13:10
SiobhyB
SiobhyB approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for wrangling @geriux!

@SiobhyB SiobhyB mentioned this pull request Jun 6, 2024
Merged
Gerardo added 2 commits June 6, 2024 17:24
Merge branch 'trunk' into release/1.120.0
066eae0 
# Conflicts:
#	gutenberg
#	ios-xcframework/Podfile.lock
#	package-lock.json
#	package.json
Update Gutenberg ref
9d4b0df
@geriux geriux merged commit 250d958 into trunk Jun 6, 2024
23 checks passed
@geriux geriux deleted the release/1.120.0 branch June 6, 2024 16:23
@twstokes
Copy link
Contributor

twstokes commented Jun 12, 2024 •
edited
Loading

🟢 Basic Test Suite Checklist (iOS)

Build: 25.1.0.0 from TestFlight
Device: iPhone 12 (iOS 17.4.1)

Writing Flow

Rich Text Format

  • TC007 - Test format detection under the cursor
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading

Unsupported Block

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

Gallery Block

  • TC005 - Choose from device (stay in editor) - Successful upload

@twstokes
Copy link
Contributor

twstokes commented Jun 12, 2024 •
edited
Loading

🟢 Test Suite 1 (iOS)

Build: 25.1.0.0 from TestFlight
Device: iPhone 12 (iOS 17.4.1)

Gallery - 1

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
    • ⚠️ The upload worked fine, but I expected to see the same thumbnail rather than the placeholder image when reopening the editor.
  • Gallery block - Close post with an ongoing image upload - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

MediaText - 1

  • Media Text block - Insert image from device (failing) - TC001
  • Media Text block - Close/Re-open post with an ongoing image upload - TC003
    • ⚠️ The upload worked fine, but I expected to see the same thumbnail rather than the placeholder image when reopening the editor.

MediaText - 2

  • Media Text block - Insert video from device - TC002-v
  • Media Text block - Insert image from device - TC002-i

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Image focal point is rendered properly - TC002
  • Cover - Custom color is rendered properly - TC002

Editor Theme - 1

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003

@twstokes
Copy link
Contributor

twstokes commented Jun 12, 2024 •
edited
Loading

🟢 New changes (iOS)

Build: 25.1.0.0 from TestFlight
Device: iPhone 12 (iOS 17.4.1)

@geriux
Copy link
Contributor Author

geriux commented Jun 13, 2024 •
edited
Loading

🟢 Basic Test Suite Checklist (Android)

Build: 25.1-rc-2
Device: Samsung Galaxy A23 5G (OS 14)

Writing Flow

Rich Text Format

  • TC007 - Test format detection under the cursor
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging

Unsupported Block

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

Gallery Block

  • TC005 - Choose from device (stay in editor) - Successful upload

@geriux
Copy link
Contributor Author

geriux commented Jun 13, 2024 •
edited
Loading

🟢 Test Suite 5 (Android)

Build: 25.1-rc-2
Device: Samsung Galaxy A23 5G (OS 14)

Video block - 1

  • Video block - Insert video from device (failing) - TC001
  • Video block - Close/Re-open post with an ongoing video upload - TC004

Video block - 2

  • Video block - Insert video from device (cancel) - TC002
  • Video block - Close post with an ongoing video upload - TC005
  • Video block - Add Caption - TC003

File block - 1

  • File block - Upload completes successfully from the device library - TC001
  • File block - Insert completes successfully from the WordPress Media library - TC002
  • File block - Upload fails from the device library - TC003
  • File block - Stop the file upload before it completes - TC004

File block - 2

  • File block - Close the post with an ongoing file upload - TC005
  • File block - Replace the selected files - TC006
  • File block - Change the alignment in the File Block - TC007
  • File block - The Link To Block Setting should open - TC008

File block - 3

  • File block - Open link in new tab - TC009
  • File block - Show/hide download button (Block Settings only) - TC010
  • File block - Copy file URL - TC011
  • File block - Close/Re-open post with an ongoing file upload - TC012

Audio block - 1

  • Audio block - Upload completes successfully from the device library - TC001
  • Audio block - Insert completes successfully from the WordPress Media library - TC002

Audio block - 2

  • Audio block - Upload fails from the device library - TC003
  • Audio block - Stop the audio file upload before it completes - TC004

Audio block - 3

  • Audio block - Close the post with an ongoing audio file upload - TC005
  • Audio block - Replace the selected files - TC006
  • Audio block - Change the alignment in the Audio Block - TC007

Audio block - 4

  • Audio block - Close/Re-open post with an ongoing audio file upload - TC010

Synced patterns - 1

  • Synced patterns - Add pattern - TC001
  • Synced patterns - Detach pattern - TC002

Synced patterns - 2

  • Synced patterns - Deleted pattern - TC003
  • Synced patterns - Recursive block rendering - TC004

Embed block - 1

  • Embed block - Inline previews are rendered correctly for the top 5 most-used providers - TC001

Embed block - 2

  • Embed block - Inline previews are rendered accordingly for each alignment option - TC002

@geriux
Copy link
Contributor Author

geriux commented Jun 13, 2024 •
edited
Loading

🟢 New changes(Android)

Build: 25.1-rc-2
Device: Samsung Galaxy A23 5G (OS 14)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiobhyB SiobhyB SiobhyB approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geriux @twstokes @SiobhyB