Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert some changes to yarn.lock #805

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

jtreanor
Copy link
Contributor

@jtreanor jtreanor commented Apr 2, 2019

#676 inadvertently made a very large number of changes to yarn.lock (> 2,000 lines added).

We reverted the PR earlier today because Jitpack builds started to fail.

This PR reverts the large number of changes to yarn.lock (I just reverted the changes and ran yarn).

You can see that the build now passes on Jitpack here.

@jtreanor jtreanor added this to the v1.2 milestone Apr 2, 2019
@jtreanor jtreanor requested review from hypest and JavonDavis April 2, 2019 15:52
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Let's merge to the parent PR and we do more extensive testing for possible regressions in that one.

@jtreanor jtreanor merged commit f0692bc into revert-803-revert-676-try/e2e-tests-appium Apr 2, 2019
@jtreanor jtreanor deleted the fix-jitpack branch April 2, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants