Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve image block accessibility on selected state #920

Merged
merged 8 commits into from
Apr 24, 2019

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Apr 23, 2019

Fixes part of: #909

Changes reside in gutenberg PR: WordPress/gutenberg#15122

To test (iOS):

Activate VoiceOver: https://github.com/wordpress-mobile/WordPress-iOS/wiki/Using-VoiceOver

To test (Android):

Activate TalkBack: https://www.wikihow.com/Enable-TalkBack-on-Your-Android
In my case, the system had a handy tutorial on how to use it.
If your version doesn't have it, it's actually very similar to VoiceOver.

Test Steps

Start with selecting the image block and then

  • Tap Edit button on toolbar and make sure it has proper title
  • Tap Settings button on image toolbar and make sure it has proper title
  • Tap Empty Caption and make sure it tells you 'Image caption. Empty'
  • Tap Filled Caption and make sure it tells you 'Image caption. '
  • When you double tap to the caption you should be able to edit
  • Tap on the image and make sure it tells you 'Image. '

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via WordPress/gutenberg#15122 (review)
Great job! 🎉

@pinarol pinarol merged commit 6290243 into develop Apr 24, 2019
@pinarol pinarol deleted the issue/909-image-block-accessiblity-selected-state branch April 24, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants