This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Improve scroll calculations with caret under keyboard at mid paragraph #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h, and behind the keyboard
2 tasks
pinarol
approved these changes
Mar 13, 2020
There was a problem hiding this comment.
This is super good! Let's 
Testing details can be found in wordpress-mobile/gutenberg-mobile#1939
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#1939This PR improves the scroll calculations when the caret is under the keyboard and not at the last line. Now the extra space between the keyboard and the caret is even for any kind of device.
To test: