Skip to content
This repository was archived by the owner on Mar 7, 2025. It is now read-only.

Conversation

ceyhun
Copy link

@ceyhun ceyhun commented Sep 20, 2021

Committed .tgz file that's created after running npm install and npm pack

Copy link

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see on other forks we included the suffix -1 in the version, shouldn't we do the same here?

Potential package version: 0.8.8-wp-1

@ceyhun
Copy link
Author

ceyhun commented Sep 24, 2021

Yeah the first fork releases I had created didn't have the -1 and we started to follow the -N convention from the second fork releases. This one didn't have a second release yet, so I think we should add the -N starting from the next release as well.

@fluiddot
Copy link

Yeah the first fork releases I had created didn't have the -1 and we started to follow the -N convention from the second fork releases. This one didn't have a second release yet, so I think we should add the -N starting from the next release as well.

I've just added the -N in this commit.

@ceyhun
Copy link
Author

ceyhun commented Sep 24, 2021

Just to note though this repo doesn't have a 0.8.8-wp-1 release yet.
Also we might need to re-pack the tarball with npm pack so it has the correct package.json and filename.

@fluiddot
Copy link

Just to note though this repo doesn't have a 0.8.8-wp-1 release yet.
Also we might need to re-pack the tarball with npm pack so it has the correct package.json and filename.

Done!

I also committed the package-lock.json file, although I noticed that on the other forks we didn't 🤔 , should we?

@ceyhun
Copy link
Author

ceyhun commented Sep 24, 2021

I'm not sure if it's taken into consideration during Gutenberg's npm install, maybe it could cause multiple versions of a certain package being installed to match the ones package-lock.json or maybe not :)

@fluiddot
Copy link

I'm not sure if it's taken into consideration during Gutenberg's npm install, maybe it could cause multiple versions of a certain package being installed to match the ones package-lock.json or maybe not :)

I see, I'll revert the change then. In this case, I think we should note that changes in the package-lock.json file shouldn't be committed, wdyt?

@ceyhun
Copy link
Author

ceyhun commented Sep 24, 2021

Yeah, I think that's closer to the current behaviour on Gutenberg CI, but again I'm not sure, it could also be just fine 🙂

@@ -1,6 +1,6 @@
{
"name": "react-native-keyboard-aware-scroll-view",
"version": "0.8.8-wp",
"version": "0.8.8-wp-1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version doesn't have a Git tag so we should create it once this gets merged.

@fluiddot fluiddot merged commit e5ce378 into wp-fork Sep 24, 2021
@fluiddot fluiddot deleted the try/tarball branch September 24, 2021 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants