-
Notifications
You must be signed in to change notification settings - Fork 2
Add tarball #15
Add tarball #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see on other forks we included the suffix -1
in the version, shouldn't we do the same here?
Potential package version: 0.8.8-wp-1
Yeah the first fork releases I had created didn't have the |
I've just added the |
Just to note though this repo doesn't have a |
Done! I also committed the |
I'm not sure if it's taken into consideration during Gutenberg's |
I see, I'll revert the change then. In this case, I think we should note that changes in the |
Yeah, I think that's closer to the current behaviour on Gutenberg CI, but again I'm not sure, it could also be just fine 🙂 |
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "react-native-keyboard-aware-scroll-view", | |||
"version": "0.8.8-wp", | |||
"version": "0.8.8-wp-1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version doesn't have a Git tag so we should create it once this gets merged.
Committed
.tgz
file that's created after runningnpm install
andnpm pack