Skip to content
This repository was archived by the owner on Mar 7, 2025. It is now read-only.

Conversation

pinarol
Copy link
Collaborator

@pinarol pinarol commented Feb 22, 2019

This PR fixes the waiting when we tap at the end of the text. Not sure about the root cause but it seems like caret y position can not be determined when it is at the end of the text. There are some similar issues on the web but no solutions. So this is a workaround but we can happily fallback to scrolling till the bottom of the component when caret is at the end anyway. And it is already what JS side does when we can't detect caret's position.

Problematic case:

caret-warning

Will add WPiOS PR here.

TO TEST:

Also:

  • test typing in the middle of the block and verify we can follow caret to the newlines
  • test with merging/splitting blocks and verify we don't lose caret under the keyboard

@pinarol pinarol added the bug Something isn't working label Feb 22, 2019
@pinarol pinarol self-assigned this Feb 22, 2019
@pinarol pinarol requested a review from etoledom February 22, 2019 14:05
Copy link

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well ✨
Thanks for fixing this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants