This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Replace isDescendant check with a more decent one #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
etoledom
approved these changes
Mar 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix: wordpress-mobile/gutenberg-mobile#717
Autoscroll should only occur if the focused textInput is a subview of the scroll view. React native's UIManager.viewIsDescendantOf makes the check using shadows views and it generates true even if our TextInput is inside a new modal UIViewController, we don't want that. We just want a simple subview check like this: https://developer.apple.com/documentation/uikit/uiview/1622521-isdescendant
So we are replacing that check to avoid unwanted autoscrolls triggered from views that doesn't belong to our scrollview.
Test with:
gutenberg-mobile PR wordpress-mobile/gutenberg-mobile#767
WPiOS PR wordpress-mobile/WordPress-iOS#11298