Make EditText selectable when view attached to window #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ArrayList<View> allEditTextsInViewGroup = getAllEditTextChildren(holder.itemView); | ||
| for (View child : allEditTextsInViewGroup) { | ||
| EditText editText = (EditText) child; | ||
| // by default, an EditText that is focusable should also be selectable, so |
There was a problem hiding this comment.
It seems to me that we're making a strong assumption here. This could work in our case, but I can have an EditText that is focusable but not selectable.
Should we check textIsSelectable before resetting it to true?
There was a problem hiding this comment.
I agree it is an assumption. Unfortunately there is no query API for this. However, I can't think of a practical case where it makes sense to use an EditText that is focused but can't be selected. It may make sense for TextView though. We can certainly live without that in this fwiw.
12 tasks
|
I think this PR is probably too old by now to consider. WDYT about closing it @mzorz ? |
|
Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been detected that RN's
TextInputcomponents within the list, that are shown offscreen when the list is first loaded, do not allow their text to be selected.Background
On the technical side, apparently the problem with RN’s
TextInputshould be fixed in this commit facebook/react-native@89340f1 but we can see it still happens, and for some reason while this code exists for TextView, this modification is not on EditText anymore (see current RN master https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java)(EDIT: the code has been reverted super shortly after in facebook/react-native@862136a#diff-457fd2ba359cc6fbb0c471516e279696, with the apparent intention to get it back in but never did).
As a workaround, this PR makes sure any EditText that's within a list row view hierarchy gets set to selectable if focusable when it gets attached to the window (that is, when it's about to become visible and hence actionable).
To test:
Before:
helloin theTextInputis selectable in the first few rows being shownAfter:
Repeat the steps above and observe all
TextInputis selectable.