Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guteneberg] Replace 'steps' with test case number #113

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

jhnstn
Copy link
Member

@jhnstn jhnstn commented Mar 23, 2022

Sometimes Github links to the wrong heading when clicking on a test case. Showing the test case in the markdown link makes it easier to verify the link went to the right test. Seeing the test cases in each group also allows for running through a sequence of tests without having to refer back to the test list after each test.

@jhnstn jhnstn requested a review from hypest March 23, 2022 15:15
@@ -64,8 +64,8 @@ This holds a grouping of certain test suites to run in order to share the work w

### MediaText - 2

- [ ] Media Text block - Insert video from device (TC002) - [steps](https://github.com/wordpress-mobile/test-cases/blob/master/test-cases/gutenberg/media-text.md#tc002-v)
- [ ] Media Text block - Insert image from device (TC002) - [steps](https://github.com/wordpress-mobile/test-cases/blob/master/test-cases/gutenberg/media-text.md#tc002-i)
- [ ] Media Text block - Insert video from device (TC002) - [TC002-v](https://github.com/wordpress-mobile/test-cases/blob/master/test-cases/gutenberg/media-text.md#tc002-v)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the (TC002) preceding the link is of any use at this stage 🤔 . WDYT about removing it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(btw, same for the line right below this one)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm yeah, I guess the sub task notation is enough i.e. TC002-v

Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Jason!

I've only left a minor comment about removing an extra mention of a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants