Make wordnet APIs async #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hijonathan
changed the title
|
Hi @hijonathan, glad that you found the code useful and chose to spend time on modernising it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋 .
Admittedly I got a little carried away with this, but I was hoping to use this library and thought it could use some improvements, namely updating it to use promises.
I've included tests and (loosely) verified that it passes with the existing codebase, though the API change is breaking. I made a branch for just tests and can merge that first if you'd like. I also used
tapesince that seems to be what you use in other repos.Sorry for the big PR. I tried to make as few changes as possible, but since everything seems to use callbacks it was unavoidable.