-
Notifications
You must be signed in to change notification settings - Fork 5
Update example orch #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Started to bring things up-to-date and deal with some TODO items
requires-python = ">=3.12" | ||
dependencies = [ | ||
"deepdiff==8.0.1", | ||
"orchestrator-core==4.0.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was discussing this with Thomas yesterday, do you think there's any reason to keep the core version specified here? It was in the requirements.txt before which historically was added to specify extra dependencies, but orchestrator-core is already in the docker image so I'm not sure why we'd want to install it again. I'd say we just remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends. This dependency section was generated via uv add -r requirements.txt
from the requirements.txt file in the project root. I think this relates to your other comment, in that if we switch to installing via uv
in the entrypoint.sh
script, we will need to
- Make sure the orchestrator-core Docker images on ghcr.io include
uv
executable - Change the
RUN
commands for the build in the Dockerfile to be compatible withuv
's process, if that's the direction we want to go
@@ -1,3 +1,14 @@ | |||
[project] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would make sense to me if the entrypoint.sh script installed dependencies with uv instead of requirements.txt, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my other comment for reference
This PR adds a SQL dump of the base netbox schema to
docker/postgresql/init.sql
to decrease startup time. It also adds the ability to overload the image used byorchestrator
andorchestrator-frontend
services viaORCH_BACKEND_TAG
andORCH_UI_TAG
compose variables.