This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Upgrade EUI and React and Uniforms + remove theme + support for USED_BY_SUBSCRIPTION_IDS #93
Merged
+44,621
−9,557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acidjunk
changed the title
Update from remove-theme-and-upgrade-react
Upgrade EUI and React and Uniforms + remove theme
Mar 10, 2022
Mark90
reviewed
Mar 10, 2022
Mark90
reviewed
Mar 10, 2022
…it EUI compliant again
acidjunk
force-pushed
the
remove-theme-and-upgrade-react
branch
from
March 24, 2022 15:13
64430cf
to
610d26d
Compare
pboers1988
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… the whole group of ID's
acidjunk
changed the title
Upgrade EUI and React and Uniforms + remove theme
Upgrade EUI and React and Uniforms + remove theme + support for USED_BY_SUBSCRIPTION_IDS
Apr 4, 2022
pboers1988
approved these changes
Apr 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Mark90
reviewed
Apr 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GENERATE_SOURCEMAP=false
to envDark theme:
To separate ticket:
GENERATE_SOURCEMAP=false
in ENV is needed for now: more inforeact-scripts start
fails when bothHOST
in.env
andproxy
inpackage.json
are defined. facebook/create-react-app#11762The proxy behaves weird when starting the dev server from the SURF office network. It will fail with: