Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Upgrade EUI and React and Uniforms + remove theme + support for USED_BY_SUBSCRIPTION_IDS #93

Merged
merged 38 commits into from
Apr 5, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 10, 2022

  • Upgrade EUI, React, Webpack, Uniforms, React-Table and Highlights
  • Upgrade other packages that can be done
  • Fix circular imports
  • Fix translations
  • Update Typescript interfaces for uniforms
  • Check if other deps can also be upgraded to newer versions
  • Check if we still need craco and adapt accordingly
  • add GENERATE_SOURCEMAP=false to env
  • add theme selection to app context
  • Add some links to docs (POC)
  • Fix link handling on metadata pages (it now reloads kinda hard)
  • support for collapsable USED_BY_SUBSCRIPTION_IDS

Dark theme:

  • Remove remaining hard coded background colors: LIR prefix page, Process detail
  • Try to improve the table background color for odd and even rows
  • Try to fix React-Select in dark mode (this probably involves adding the mode to the app context so we can

To separate ticket:

 - options.allowedHosts[0] should be a non-empty string.```
  This can be circumvented by:
```DANGEROUSLY_DISABLE_HOST_CHECK=true yarn start```

Sorry, something went wrong.

@acidjunk acidjunk changed the base branch from main to remove-theme March 10, 2022 12:17
@acidjunk acidjunk changed the title Update from remove-theme-and-upgrade-react Upgrade EUI and React and Uniforms + remove theme Mar 10, 2022
src/locale/i18n.ts Outdated Show resolved Hide resolved
src/locale/i18n.ts Outdated Show resolved Hide resolved
@acidjunk acidjunk changed the base branch from remove-theme to main March 21, 2022 10:35
@acidjunk acidjunk force-pushed the remove-theme-and-upgrade-react branch from 64430cf to 610d26d Compare March 24, 2022 15:13
Copy link
Member

@pboers1988 pboers1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acidjunk acidjunk changed the title Upgrade EUI and React and Uniforms + remove theme Upgrade EUI and React and Uniforms + remove theme + support for USED_BY_SUBSCRIPTION_IDS Apr 4, 2022
Copy link
Member

@pboers1988 pboers1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pboers1988 pboers1988 merged commit 21f6c70 into main Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants