Skip to content

render exports #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

render exports #2232

wants to merge 5 commits into from

Conversation

timfdev
Copy link
Collaborator

@timfdev timfdev commented Oct 8, 2025

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: eb1b2b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

DutchBen
DutchBen reviewed Oct 8, 2025
View reviewed changes
packages/orchestrator-ui-components/src/components/WfoAgent/ExportButton/ExportButton.tsx
import { csvDownloadHandler } from '@/utils/csvDownload';

export type ExportData = {
action: string;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see only the download_url and entity_type properties are use in the button right? Or am I missing something? If so I think we should simplify this and add these to the ExportButtonProps directly.

DutchBen
DutchBen reviewed Oct 8, 2025
View reviewed changes
packages/orchestrator-ui-components/src/components/WfoAgent/ExportButton/ExportButton.tsx
boxShadow: `0 ${theme.size.xs} ${theme.size.base} ${theme.colors.primary}35`,
}}
>
{isFetching ? 'Downloading...' : 'Download CSV'}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translate?

DutchBen
DutchBen reviewed Oct 8, 2025
View reviewed changes
packages/orchestrator-ui-components/src/components/WfoAgent/WfoAgent/WfoAgent.tsx
type SearchState = {
parameters: AnySearchParameters;
results: AnySearchResult[];
export_data?: ExportData | null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camelCase

Suggested change
export_data?: ExportData | null;
exportData?: ExportData | null;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DutchBen DutchBen DutchBen approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timfdev @DutchBen