Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preact [WIP] #113

Merged
merged 50 commits into from
Apr 3, 2018
Merged

Preact [WIP] #113

merged 50 commits into from
Apr 3, 2018

Conversation

btzr-io
Copy link
Contributor

@btzr-io btzr-io commented Mar 31, 2018

Changes

Done

Todo

  • Port Reader
  • Port Library

@workhorsy
Copy link
Owner

Nice! I'll see if I can test this out tonight.

@workhorsy
Copy link
Owner

Testing it now. Looks good.

@workhorsy
Copy link
Owner

You should add yourself to the copyrights.

You could also update the copyright footer. Something like this maybe? I'm not sure what to put on a website copyright footer, when there are multiple copyright holders:

Copyright © 2017 - 2018 Comic Book Reader Developers

@btzr-io
Copy link
Contributor Author

btzr-io commented Apr 1, 2018

I think that makes sense, I found a tool to handle contributors -> all-contributors-cli
I'll add it to the repo ^^

@workhorsy
Copy link
Owner

If I pull this into my preact branch, and you make more changes, will it let me merge it again? Or will it close the pull request? I'm not sure how that works. I've never had to pull from the same branch multiple times.

@btzr-io
Copy link
Contributor Author

btzr-io commented Apr 3, 2018

not sure, but you can merge this PR if you want ,
I think we should make a new PR or branch for the reader / viewer...

@workhorsy
Copy link
Owner

Crossing fingers.

@workhorsy workhorsy merged commit 553640a into workhorsy:preact Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants