Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add socket count #172

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

benjaminlebigot
Copy link

Hi,

Thanks for your work, we are using your library to retrieve hardware information which we use to estimate environmental impact of pools of servers. Your work has saved us a lot of time, thanks again.

Adding the socket count retrieved from /proc/cpuinfo.

A patch was needed on the functions: _get_field(), _get_field_actual() in order to retrieve the max value of a
given field.

Tests have been adapted and are all passing.

Don't hesitate to contact me for any further information or adaptation.

@workhorsy
Copy link
Owner

I'm trying to make py-cpuinfo work consistently on every platform (Linux/Windows/OSX/BeOS/Haiku/Solaris). This looks to only gets socket count on Linux. If I add the ability to get socket count, it needs to work consistently on every platform. Plus it looks like it uses curses, which I don't think works on every platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants