Move polyfill from a module import to "native" Ember.String.isHTMLSafe #2
Conversation
This takes a cue from `ember-getowner-polyfill` and `ember-assign-polyfill`.
|
@rwjblue @kellyselden Would either of you have any interest in reviewing since you commented on #1? Seems pretty straightforward to me. |
LICENSE.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| The MIT License (MIT) | |||
|
|
|||
| Copyright (c) 2016 | |||
| Copyright (c) 2017 | |||
There was a problem hiding this comment.
ember-cli made a mistake here (and we are revertting the update to the LICENSE.md blueprint).
@Panman8201 - Can you change this to 2016-2017 instead of just updating to 2017?
There was a problem hiding this comment.
I actually manually made that change, not ember-cli's fault! :) I'll change it to your suggestion.
README.md
Outdated
| ## Compatibility | ||
|
|
||
| This addon is tested against each minor ember version starting with 1.10 through 2.5. Additionally tested against, | ||
| `ember-stable`, `ember-beta`, and `ember-canary`. A complete list can be found in the [`ember-try.js](https://github.com/workmanw/ember-string-ishtmlsafe-polyfill/blob/master/config/ember-try.js) config. | ||
| This addon is tested against each minor ember version starting with 1.10 through 2.8 |
|
@rwjblue Thank you! |
|
So this brings up an interesting question, normally I'd make the suggested changes and squash, but since there are multiple unique commits here I can't do that.?. Or can I say squash "these two separate commits"?? (Not a git expert just yet.) Or should I just ignore this a push another commit for "PR review changes"? |
|
You can absolutely do that. It may involve multiple steps though. The way I would do it is to check out the base commit you want to squash with, then cherry-pick your changed commit on top, squash those two together. Then rebase the rest of the commits back on top of that new tree. Does that make sense? It's perfectly fine to also just push a 5th commit that is "PR review changes". This addon doesn't have, and likely won't have, a high volume of commits. A few extra is perfectly fine with me :) |
|
Ug... I tried but failed, had to reset a couple times. Just pushed the commit separately, looks like Travis is running tests now. |
|
Thanks again! I'm going to get a new version of this released later today. Probably go to |
|
No problem! I try to contribute where/when I feel that I'm able. 😄 Yeah, |
|
Looks like it's working great kellyselden/ember-awesome-macros#256 |
This largely comes from ember-getowner-polyfill and ember-assign-polyfill. Also includes ember-cli updates and added test scenarios (separate commits).
The current way of importing the function still works but throws a deprecation message so it should be ok to release as 1.0.2.
Note,
ember initwanted to change the order of a few things inpackage.json. I've found it best to allow it, makes it easier to update down the road..Resolves #1