Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ES6 and Babel #43

Closed
kohei-takata opened this issue Jul 20, 2015 · 6 comments · Fixed by #69
Closed

Use ES6 and Babel #43

kohei-takata opened this issue Jul 20, 2015 · 6 comments · Fixed by #69

Comments

@kohei-takata
Copy link
Collaborator

No description provided.

@aksharpatel47
Copy link

I would like to help out with this issue. Can someone can point me in the right direction?

@kohei-takata
Copy link
Collaborator Author

Hi @aksharpatel47 !
Thank you for your comment!

I think files in learnyoureact/exercises/*/solution/, and problem.*.md files can be changed.
Files will be .jsx or .js or .md.
Once you change .jsx files, please add transformViews option in solution.js file.
After that it will move correctly.

After change .js files, please use Babel to transpile the file.

Finally, you must change .md files of question.

Please ask me anything if you have any questions while changing.
Thanks.

Kohei

@aksharpatel47
Copy link

Hi @tako-black

Thanks for replying. I'll get to work on it and will let you know in case I need your help.

@atuttle
Copy link
Contributor

atuttle commented Oct 26, 2015

Another related issue is that the examples currently use node-jsx which has been deprecated in favor of Babel. I'm not good enough with Babel yet to know how to rewrite the sample app using it, but I figured I'd mention that.

@kohei-takata
Copy link
Collaborator Author

Hi @atuttle
Thanks for your mention!
I think require('node-jsx').install() should be require('babel/register').

@atuttle
Copy link
Contributor

atuttle commented Oct 27, 2015

I tried your suggestion (even did npm uninstall node-jsx) and it worked. Seems good to me! I'll get a PR in to make that change, soon.

kohei-takata added a commit that referenced this issue Oct 28, 2015
relates to #43: convert from node-jsx to babel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants