Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html_stream, support for multiple 'loud' tags #146

Closed
wants to merge 2 commits into from

Conversation

dbencic
Copy link

@dbencic dbencic commented Jul 1, 2015

Current implementation transforms only first 'loud' element to uppercase, others are ignored.

dbencic added 2 commits July 2, 2015 00:02
This solution supports multiple elements with 'loud' class. Previous solution transforms only first one.
Copy link
Member

@kalinchernev kalinchernev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good suggestion.

@ccarruitero
Copy link
Contributor

Thanks @dbencic for the PR. Sorry that was reviewed at time.

I'm closing this, since we are planing to remove trumpet dependency (#239) now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants