chore: remove unnecessary PHPStan ignored errors

worksome · Jan 4, 2023 · 8c46503 · 8c46503
1 parent 0964a7e
commit 8c46503
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 9 deletions.
diff --git a/src/Commands/ViewLatestRatesCommand.php b/src/Commands/ViewLatestRatesCommand.php
@@ -19,7 +19,7 @@ final class ViewLatestRatesCommand extends Command
     use HasUsefulConsoleMethods;
 
     public $signature = 'exchange:rates
-        {base_currency? : The base currency to convert from.}
+        {base-currency? : The base currency to convert from.}
         {currencies?* : Any number of currencies to fetch exchange rates for.}';
 
     public $description = 'Retrieve exchange rates for a given set of currencies.';
@@ -53,7 +53,7 @@ private function data(CurrencyCodeProvider $currencyCodeProvider): array
         $givenCurrencies = $this->argument('currencies');
 
         return [
-            'base_currency' => $this->argument('base_currency') ?? $this->ask(
+            'base_currency' => $this->argument('base-currency') ?? $this->ask(
                 'Which base currency do you want to use?'
             ),
             'currencies' => count($givenCurrencies) > 0 ? $givenCurrencies : $this->choice(

diff --git a/src/ExchangeRateProviders/CachedProvider.php b/src/ExchangeRateProviders/CachedProvider.php
@@ -23,7 +23,6 @@ public function getRates(string $baseCurrency, array $currencies): Rates
     {
         $currenciesForKey = implode(',', Arr::sort($currencies));
 
-        // @phpstan-ignore-next-line
         return $this->cache->remember(
             "{$this->key}:{$baseCurrency}:{$currenciesForKey}",
             $this->ttl,

diff --git a/src/ExchangeRateProviders/NullProvider.php b/src/ExchangeRateProviders/NullProvider.php
@@ -13,7 +13,6 @@ public function getRates(string $baseCurrency, array $currencies): Rates
     {
         return new Rates(
             $baseCurrency,
-            // @phpstan-ignore-next-line
             array_fill_keys($currencies, 1.0),
             now()
         );

diff --git a/src/Support/ExchangeRateManager.php b/src/Support/ExchangeRateManager.php
@@ -35,7 +35,6 @@ public function createFixerDriver(): FixerProvider
         ));
 
         return new FixerProvider(
-            // @phpstan-ignore-next-line
             $this->container->make(Factory::class),
             $apiKey,
         );
@@ -44,23 +43,20 @@ public function createFixerDriver(): FixerProvider
     public function createExchangeRateDriver(): ExchangeRateHostProvider
     {
         return new ExchangeRateHostProvider(
-            // @phpstan-ignore-next-line
             $this->container->make(Factory::class),
         );
     }
 
     public function createFrankfurterDriver(): FrankfurterProvider
     {
         return new FrankfurterProvider(
-            // @phpstan-ignore-next-line
             $this->container->make(Factory::class),
         );
     }
 
     public function createCacheDriver(): CachedProvider
     {
         return new CachedProvider(
-            // @phpstan-ignore-next-line
             $this->container->make(Repository::class),
             // @phpstan-ignore-next-line
             $this->driver($this->config->get('exchange.services.cache.strategy')),

diff --git a/src/Testing/FakeExchangeRateProvider.php b/src/Testing/FakeExchangeRateProvider.php
@@ -52,7 +52,6 @@ public function assertRetrievedRates(int $times = 1): self
      */
     private function getRatesArray(array $currencies): array
     {
-        // @phpstan-ignore-next-line
         return array_merge(array_fill_keys($currencies, 1.0), $this->predefinedRates);
     }
 }