Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solana: fix redeem fast fill stack access violation #205

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

a5-pickle
Copy link
Contributor

Direct data mapping being enabled avoided this stack access violation from cropping up in the local validator test. In order to safely test any instruction's potential stack access violations, disable this feature: https://github.com/solana-labs/solana/blob/27eff8408b7223bb3c4ab70523f8a8dca3ca6645/sdk/src/feature_set.rs#L616.

Fix for token router: moar boxing

Copy link
Contributor

@gator-boi gator-boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@a5-pickle a5-pickle merged commit fd73007 into main Oct 31, 2024
6 checks passed
@a5-pickle a5-pickle deleted the redeem-fill-error branch October 31, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants