solana: token router transfer authority and more #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5-pickle
force-pushed
the
solana/another-transfer-authority
branch
from
fbe045e to
4ee154b
Compare
gator-boi
reviewed
Apr 4, 2024
|
|
||
| #[account(token::mint = mint)] | ||
| // TODO: Do we add a restriction that the refund token account must be the same owner as the |
There was a problem hiding this comment.
What would we be protecting against with this check?
There was a problem hiding this comment.
If it's bad input by the client, then I don't think it's necessary.
gator-boi
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56.
Closes #26.
Closes #37.