feat: address audit comments #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Milap Sheth <milap.sheth2010@gmail.com>
Co-authored-by: Milap Sheth <milap.sheth2010@gmail.com>
Co-authored-by: Milap Sheth <milap.sheth2010@gmail.com>
Co-authored-by: Milap Sheth <milap.sheth2010@gmail.com>
Co-authored-by: Milap Sheth <milap.sheth2010@gmail.com>
canhtrinh
previously approved these changes
Jun 27, 2024
Foivos
changed the base branch from
feat/update-wormhole-examples-version
to
main
Foivos
dismissed stale reviews from canhtrinh and djb15
The base branch was changed.
milapsheth
reviewed
Jun 28, 2024
Comment on lines
22
to
24
| /// @notice Chain Id is already being used. | ||
| error ChainIdAlreadySet(uint16 chainId); | ||
|
|
There was a problem hiding this comment.
Suggested change
| /// @notice Chain Id is already being used. | |
| error ChainIdAlreadySet(uint16 chainId); | |
| /// @notice Chain Id is already being used. | |
| error ChainIdAlreadySet(uint16 chainId); | |
| /// @notice Axelar chain Id is already being used. | |
| error AxelarChainIdAlreadySet(string axelarChainId); | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.