More tests

wormhole-foundation · Feb 1, 2023 · 5aa0843 · 5aa0843
1 parent c74b43d
commit 5aa0843
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/x/wasm/client/cli/gov_tx.go b/x/wasm/client/cli/gov_tx.go
@@ -597,7 +597,7 @@ func ProposalUnpinCodesCmd() *cobra.Command {
 	return cmd
 }
 
-func parseAccessConfig(raw string) (types.AccessConfig, error) {
+func parseAccessConfig(raw string) (c types.AccessConfig, err error) {
 	switch raw {
 	case "nobody":
 		return types.AllowNobody, nil
@@ -613,6 +613,11 @@ func parseAccessConfig(raw string) (types.AccessConfig, error) {
 			}
 			addrs[i] = addr
 		}
+		defer func() { // convert panic in ".With" to error for better output
+			if r := recover(); r != nil {
+				err = r.(error)
+			}
+		}()
 		cfg := types.AccessTypeAnyOfAddresses.With(addrs...)
 		return cfg, cfg.ValidateBasic()
 	}

diff --git a/x/wasm/client/cli/gov_tx_test.go b/x/wasm/client/cli/gov_tx_test.go
@@ -70,6 +70,18 @@ func TestParseAccessConfigUpdates(t *testing.T) {
 				},
 			},
 		},
+		"any of addresses - empty list": {
+			src:    []string{"1:"},
+			expErr: true,
+		},
+		"any of addresses - invalid address": {
+			src:    []string{"1:foo"},
+			expErr: true,
+		},
+		"any of addresses - duplicate address": {
+			src:    []string{"1:cosmos1vx8knpllrj7n963p9ttd80w47kpacrhuts497x,cosmos1vx8knpllrj7n963p9ttd80w47kpacrhuts497x"},
+			expErr: true,
+		},
 	}
 	for name, spec := range specs {
 		t.Run(name, func(t *testing.T) {