don't throw in token bridge lookup #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnjamin
reviewed
Jun 6, 2024
| try { | ||
| return [await TokenTransfer.lookupDestinationToken(fromChain, toChain, sourceToken)]; | ||
| } catch (e) { | ||
| console.error(`Failed to get destination token: ${e}`); |
There was a problem hiding this comment.
I dont love the console.errors, but we need a general strat around what/when/where we console.error
There was a problem hiding this comment.
better would be to not even throw here and just return something akin to a Result (Some(token) | None)
barnjamin
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevents a throw that happens here from crashing routes
really this should return something like a
Resultwith eitherSome(token)orNoneinstead of throwing... but this will do for now :-)