Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sui vite fix #658

Merged
Merged

Conversation

kev1n-peters
Copy link
Collaborator

No description provided.

There is an issue with vite/rollup where the platform is being set
to undefined when running an app built with the SDK on the local dev server.

A similar issue was fixed here: wormhole-foundation#615

It's not clear what the root cause is and if it's an actual bug in vite/rollup
or in the SDK.
@kev1n-peters kev1n-peters requested a review from emreboga August 7, 2024 12:53
Copy link
Collaborator

@emreboga emreboga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kev1n-peters kev1n-peters merged commit e91bcce into wormhole-foundation:main Aug 7, 2024
@kev1n-peters kev1n-peters deleted the sui-vite-fix branch August 7, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants