Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: arbitrum watcher fix #1812

Merged
merged 3 commits into from
Oct 28, 2022
Merged

node: arbitrum watcher fix #1812

merged 3 commits into from
Oct 28, 2022

Conversation

bruce-riley
Copy link
Contributor

Somehow this change to poller.go did not get committed with the previous PR.

@evan-gray evan-gray requested a review from panoel October 28, 2022 00:23
evan-gray
evan-gray previously approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Should there be a comment that L1BlockNumber is part of the Arbitrum spec?

evan-gray
evan-gray previously approved these changes Oct 28, 2022
View reviewed changes
hendrikhofstadt
hendrikhofstadt suggested changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@hendrikhofstadt hendrikhofstadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nit on the comment

@evan-gray evan-gray merged commit 914aa99 into dev.v2 Oct 28, 2022
@evan-gray evan-gray deleted the node_arbitrum_watcher_fix branch October 28, 2022 12:15
This was referenced Jul 6, 2023
Open
Open
@St0nersdash St0nersdash mentioned this pull request Jul 6, 2023
Open
@paradiseisbeautiful paradiseisbeautiful mentioned this pull request Jul 6, 2023
Open
@St0nersdash St0nersdash mentioned this pull request Jul 7, 2023
Merged
@davidevernizzi davidevernizzi mentioned this pull request Jul 7, 2023
Open
@paradiseisbeautiful paradiseisbeautiful mentioned this pull request Oct 12, 2024
Open
@Mustafaovais Mustafaovais mentioned this pull request Oct 12, 2024
Open
@Pwn20wn Pwn20wn mentioned this pull request Oct 12, 2024
Open
@davidevernizzi davidevernizzi mentioned this pull request Oct 12, 2024
Open
This was referenced Oct 12, 2024
Open
Open
@paradiseisbeautiful paradiseisbeautiful mentioned this pull request Oct 15, 2024
Open
@Mustafaovais Mustafaovais mentioned this pull request Oct 15, 2024
Open
@davidevernizzi davidevernizzi mentioned this pull request Oct 15, 2024
Open
@Mustafaovais Mustafaovais mentioned this pull request Oct 16, 2024
Open
This was referenced Oct 16, 2024
Open
Open
@Nguyendinhtuan17 Nguyendinhtuan17 mentioned this pull request Oct 16, 2024
Open
This was referenced Oct 16, 2024
Open
Open
@Mustafaovais Mustafaovais mentioned this pull request Oct 17, 2024
Open
@Nguyendinhtuan17 Nguyendinhtuan17 mentioned this pull request Oct 17, 2024
Open
@paradiseisbeautiful paradiseisbeautiful mentioned this pull request Oct 19, 2024
Open
@Mustafaovais Mustafaovais mentioned this pull request Oct 19, 2024
Open
@Pwn20wn Pwn20wn mentioned this pull request Oct 19, 2024
Open
This was referenced Oct 19, 2024
Open
Open
@Pwn20wn Pwn20wn mentioned this pull request Oct 20, 2024
Open
@davidevernizzi davidevernizzi mentioned this pull request Oct 20, 2024
Open
@paradiseisbeautiful paradiseisbeautiful mentioned this pull request Oct 22, 2024
Open
@Mustafaovais Mustafaovais mentioned this pull request Oct 22, 2024
Open
@davidevernizzi davidevernizzi mentioned this pull request Oct 22, 2024
Open
@Mustafaovais Mustafaovais mentioned this pull request Oct 23, 2024
Open
This was referenced Oct 23, 2024
Open
Open
@Nguyendinhtuan17 Nguyendinhtuan17 mentioned this pull request Oct 23, 2024
Open
This was referenced Oct 23, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-gray evan-gray evan-gray approved these changes

@hendrikhofstadt hendrikhofstadt hendrikhofstadt approved these changes

@panoel panoel Awaiting requested review from panoel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bruce-riley @hendrikhofstadt @evan-gray