node: commit proto and matching test fixes #1769 #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-gray
force-pushed
the
go-proto-gen
branch
from
e2133d3
to
f35642d
Compare
|
evidence of test breaking when a proto change is made without committing the corresponding generated code: https://github.com/wormhole-foundation/wormhole/actions/runs/3349436581/jobs/5549438027 |
evan-gray
force-pushed
the
go-proto-gen
branch
from
f35642d
to
a66abfe
Compare
|
proving a failure case by manipulating the generated go code https://github.com/wormhole-foundation/wormhole/actions/runs/3349468198/jobs/5549500358 |
evan-gray
force-pushed
the
go-proto-gen
branch
from
6a03b82
to
a66abfe
Compare
|
For awareness @conorpp |
hendrikhofstadt
suggested changes
Oct 31, 2022
evan-gray
force-pushed
the
go-proto-gen
branch
2 times, most recently
from
629b92d
to
8f9bc77
Compare
evan-gray
force-pushed
the
go-proto-gen
branch
from
8f9bc77
to
123aa6f
Compare
hendrikhofstadt
approved these changes
Oct 31, 2022
kcsongor
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anyone including the node code as a dependency from github breaks on the missing protos. This PR adds the generated go protos along with a CI check to ensure they always match the protos themselves. Added bonus there's one less step for Tilt to do.