Node: Neon Watcher Redesign #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
changed the title
bruce-riley
requested review from
hendrikhofstadt,
jynnantonix and
leoluk
as code owners
jumpsiegel
approved these changes
Nov 12, 2022
There was a problem hiding this comment.
One of the feedbacks we have gotten from auditors is maybe we should wrap the standard arguments for these watchers into a "object" to reduce the total number of arguments in the function. If you think about how you would actually then set all those arguments, it would be just as ugly...
hendrikhofstadt
approved these changes
Nov 14, 2022
panoel
approved these changes
Nov 14, 2022
This was referenced Dec 13, 2022
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Neon watcher to wait for finality on Solana before publishing Neon blocks.
Fixes #1898