Node/Watcher: Allow retry of EVM get time of block #2527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panoel
reviewed
Mar 16, 2023
panoel
reviewed
Mar 16, 2023
panoel
approved these changes
Mar 16, 2023
|
This should eventually be fixed upstream in the moonbeam node: moonbeam-foundation/moonbeam#2168 |
|
I hear this fix will be in the next runtime (late July) |
bruce-riley
force-pushed
the
node/watcher_allow_retry_of_evm_get_time_of_block
branch
from
85b3ea2
to
45c29fb
Compare
|
Moonbeam addressed this problem on their end, so this PR is no longer necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Moonbeam the TimeOfBlockByHash() call is occasionally failing. We believe this is due to a race condition where Moonbeam is publishing log messages before the block is available for querying (possibly before the block is finalized). We are working with the Moonbeam team to see if they can identify and fix the issue on their side. In the meantime, this PR attempts to retry the request a second time, in hope of preventing the Moonbeam watcher runnable from dying.