-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy Mantle to testnet #3438
Merged
Merged
Deploy Mantle to testnet #3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
force-pushed
the
deploy_scroll_testnet
branch
from
October 27, 2023 16:34
8915603
to
2207980
Compare
bruce-riley
force-pushed
the
deploy_scroll_testnet
branch
3 times, most recently
from
November 8, 2023 18:02
f7a9778
to
88fb571
Compare
bruce-riley
force-pushed
the
deploy_mantle_testnet
branch
5 times, most recently
from
November 13, 2023 18:25
a264675
to
978f386
Compare
bruce-riley
requested review from
panoel,
kev1n-peters,
evan-gray,
SEJeff,
a5-pickle,
barnjamin,
gator-boi and
kcsongor
as code owners
November 27, 2023 20:16
bruce-riley
force-pushed
the
deploy_mantle_testnet
branch
from
November 27, 2023 20:34
978f386
to
9270908
Compare
a5-pickle
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed ethereum and rust/core/src
bruce-riley
force-pushed
the
deploy_mantle_testnet
branch
from
December 1, 2023 15:42
9270908
to
caaa9c3
Compare
bruce-riley
force-pushed
the
deploy_mantle_testnet
branch
2 times, most recently
from
December 7, 2023 21:39
7636132
to
490ed31
Compare
evan-gray
previously approved these changes
Dec 8, 2023
panoel
previously approved these changes
Dec 8, 2023
SEJeff
previously approved these changes
Dec 8, 2023
bruce-riley
dismissed stale reviews from SEJeff, panoel, and evan-gray
via
December 11, 2023 14:21
b9686a3
bruce-riley
force-pushed
the
deploy_mantle_testnet
branch
from
December 11, 2023 14:21
490ed31
to
b9686a3
Compare
a5-pickle
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resubmitting approval. No changes to the previous directories I reviewed
barnjamin
approved these changes
Dec 11, 2023
panoel
approved these changes
Dec 11, 2023
SEJeff
approved these changes
Dec 11, 2023
evan-gray
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for Mantle in testnet. Note that the watcher does not yet properly handle finality, so this chain should not be enabled in mainnet (and this PR actually prevents that).