Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCQ/Node/EVM: Refactor #3542

Merged
merged 2 commits into from
Nov 28, 2023
Merged

CCQ/Node/EVM: Refactor #3542

merged 2 commits into from
Nov 28, 2023

Conversation

bruce-riley
Copy link
Contributor

@bruce-riley bruce-riley commented Nov 16, 2023

This code reduces the amount of code that is duplicated between the eth_call, eth_call_by_timestamp and eth_call_with_finality.

This PR also fixes #3539.

@bruce-riley bruce-riley changed the base branch from main to ccq/node/evm_logger_cleanup November 16, 2023 20:23
@bruce-riley bruce-riley force-pushed the ccq/node/evm_refactor branch 3 times, most recently from 41bf6d9 to 93429b8 Compare November 16, 2023 21:01
Base automatically changed from ccq/node/evm_logger_cleanup to main November 17, 2023 17:52
@bruce-riley bruce-riley marked this pull request as ready for review November 20, 2023 22:24
panoel
panoel previously approved these changes Nov 20, 2023
node/pkg/watchers/evm/ccq.go Outdated Show resolved Hide resolved
node/pkg/watchers/evm/ccq.go Outdated Show resolved Hide resolved
node/pkg/watchers/evm/ccq.go Outdated Show resolved Hide resolved
evan-gray
evan-gray previously approved these changes Nov 27, 2023
node/pkg/watchers/evm/ccq.go Show resolved Hide resolved
node/pkg/watchers/evm/ccq.go Show resolved Hide resolved
@bruce-riley bruce-riley merged commit 36a82af into main Nov 28, 2023
21 of 22 checks passed
@bruce-riley bruce-riley deleted the ccq/node/evm_refactor branch November 28, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should QueryResponsePublication.RequestID() be changed as well?
3 participants