-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCQ/Node/EVM: Refactor #3542
Merged
Merged
CCQ/Node/EVM: Refactor #3542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
changed the base branch from
main
to
ccq/node/evm_logger_cleanup
November 16, 2023 20:23
bruce-riley
force-pushed
the
ccq/node/evm_logger_cleanup
branch
from
November 16, 2023 20:24
0fd00b1
to
76bdb3c
Compare
bruce-riley
force-pushed
the
ccq/node/evm_refactor
branch
3 times, most recently
from
November 16, 2023 21:01
41bf6d9
to
93429b8
Compare
bruce-riley
force-pushed
the
ccq/node/evm_refactor
branch
from
November 17, 2023 17:56
93429b8
to
6ea81ca
Compare
bruce-riley
requested review from
evan-gray,
panoel and
kev1n-peters
as code owners
November 20, 2023 22:24
bruce-riley
force-pushed
the
ccq/node/evm_refactor
branch
from
November 20, 2023 22:24
6ea81ca
to
428c08a
Compare
panoel
reviewed
Nov 20, 2023
panoel
reviewed
Nov 20, 2023
panoel
reviewed
Nov 20, 2023
panoel
previously approved these changes
Nov 20, 2023
evan-gray
requested changes
Nov 27, 2023
evan-gray
previously approved these changes
Nov 27, 2023
bruce-riley
force-pushed
the
ccq/node/evm_refactor
branch
from
November 27, 2023 22:30
698d3cf
to
6d9204f
Compare
panoel
approved these changes
Nov 28, 2023
evan-gray
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code reduces the amount of code that is duplicated between the
eth_call
,eth_call_by_timestamp
andeth_call_with_finality
.This PR also fixes #3539.