-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wormchain: allow hot-swapping validator address association when guar… #3576
Conversation
…dian set size is 1
…nts, simplify checks and code flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wormchain/x/wormhole/keeper/msg_server_register_account_as_guardian.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, left some minor comments
wormchain/x/wormhole/keeper/msg_server_register_account_as_guardian.go
Outdated
Show resolved
Hide resolved
wormchain/x/wormhole/keeper/msg_server_register_account_as_guardian.go
Outdated
Show resolved
Hide resolved
wormchain/x/wormhole/keeper/msg_server_register_account_as_guardian.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits to make the tests nicer (panic sucks in tests, please don't do that!)
Nice work!
wormchain/x/wormhole/keeper/msg_server_register_account_as_guardian_test.go
Outdated
Show resolved
Hide resolved
wormchain/x/wormhole/keeper/msg_server_register_account_as_guardian_test.go
Outdated
Show resolved
Hide resolved
wormchain/x/wormhole/keeper/msg_server_register_account_as_guardian_test.go
Outdated
Show resolved
Hide resolved
wormchain/x/wormhole/keeper/msg_server_register_account_as_guardian_test.go
Outdated
Show resolved
Hide resolved
wormchain/x/wormhole/keeper/msg_server_register_account_as_guardian_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
…dian set size is 1