Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wormchain: allow hot-swapping validator address association when guar… #3576

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

nik-suri
Copy link
Contributor

@nik-suri nik-suri commented Dec 5, 2023

…dian set size is 1

Copy link
Collaborator

@pires pires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kcsongor
kcsongor previously approved these changes Dec 5, 2023
Copy link
Contributor

@kcsongor kcsongor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, left some minor comments

SEJeff
SEJeff previously approved these changes Dec 5, 2023
Copy link
Collaborator

@SEJeff SEJeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits to make the tests nicer (panic sucks in tests, please don't do that!)

Nice work!

@nik-suri nik-suri dismissed stale reviews from SEJeff and kcsongor via 1c16f11 December 5, 2023 22:36
Copy link
Collaborator

@SEJeff SEJeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@nik-suri nik-suri merged commit 5525caa into main Dec 5, 2023
21 of 22 checks passed
@nik-suri nik-suri deleted the register-acct-as-guardian-set-1 branch December 5, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants