Node/EVM: Retry block time read #3577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
requested review from
evan-gray,
panoel and
kev1n-peters
as code owners
bruce-riley
force-pushed
the
node/evm_retry_blocktime_read
branch
from
7a65f29
to
3f2d8cc
Compare
bruce-riley
force-pushed
the
node/evm_retry_blocktime_read
branch
from
3f2d8cc
to
5f2d20f
Compare
panoel
approved these changes
Dec 6, 2023
evan-gray
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #2905, where reading the block time on a new EVM transaction can fail, possibly due to a load balancer issue. This failure kills the watcher, which has always been a problem, but will be worse now that the watcher is maintaining the timestamp to block number cache used for CCQ, so that history will be lost on a restart.
This PR adds a limited retry (every five seconds for up to three retries) before giving up on the transaction.