node: Updated governor token list update script #3588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djb15
requested review from
bruce-riley,
panoel,
kev1n-peters,
evan-gray,
claudijd and
SEJeff
as code owners
bruce-riley
previously approved these changes
Dec 11, 2023
panoel
reviewed
Dec 11, 2023
panoel
reviewed
Dec 11, 2023
panoel
previously approved these changes
Dec 11, 2023
SEJeff
previously approved these changes
Dec 12, 2023
djb15
dismissed stale reviews from SEJeff, panoel, and bruce-riley
via
3bb4491
djb15
force-pushed
the
node/governor-token-list
branch
from
ed3e21d
to
3bb4491
Compare
SEJeff
approved these changes
Dec 12, 2023
bruce-riley
approved these changes
Dec 13, 2023
djb15
added a commit
to djb15/wormhole
that referenced
this pull request
Dec 14, 2023
…3588) * node: Updated governor token list update script * node: Improved logging + PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part 1 of improving the governor token list update process to increase automation and visibility.
Specifically, this PR concerns the changes to the existing update script that find any new token additions or token removals, and any significant decreases in token price. The generated tokens list that is generated by this script is unchanged. However the script now also outputs a
changes.txtfile with a summary. This is the file that is used in the GitHub PR body.See #3587 for an example of what the PR body will look like. If there's anything about the body you'd like to change then please suggest on this PR.
This PR is accompanied by part 2 (djb15#4) which runs the automation. This is contained in a downstream fork so that we don't have to grant GitHub Action runners significant write permissions; unfortunately GH permissions are not very granular so write access for PRs means write access to the whole repository. By running the automation in a fork we can easily move the action to another org-owned fork or even upstream in the future.