Node/CCQ/Server: Clean restart #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
changed the base branch from
main
to
node/ccq/server_add_permissions_file_watcher
Base automatically changed from
node/ccq/server_add_permissions_file_watcher
to
main
December 11, 2023 20:44
evan-gray
force-pushed
the
node/ccq/server_clean_restart
branch
from
840e480
to
2334fc1
Compare
bruce-riley
force-pushed
the
node/ccq/server_clean_restart
branch
from
2334fc1
to
5934552
Compare
bruce-riley
force-pushed
the
node/ccq/server_clean_restart
branch
from
5934552
to
7c93a1e
Compare
bruce-riley
requested review from
panoel,
kev1n-peters and
evan-gray
as code owners
evan-gray
reviewed
Dec 11, 2023
panoel
reviewed
Dec 11, 2023
panoel
reviewed
Dec 11, 2023
evan-gray
previously approved these changes
Dec 11, 2023
panoel
reviewed
Dec 11, 2023
panoel
previously approved these changes
Dec 11, 2023
evan-gray
approved these changes
Dec 11, 2023
panoel
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the proxy server to handle restarts more cleanly, hopefully without dropping query requests.
It adds two new config parameters (with what should be reasonable default values):
shutdownDelay1andshutdownDelay2. When a sigterm is received, it will do the following:shutdownDelay1seconds to allow the load balancer to detect that the server is down and stop routing requests to it.shutdownDelay2seconds, but checking every second to see if there are no more pending requests.shutdownDelay2seconds), the server exits.The default values for the two config parameters are based on the default health check parameter values. We may want to tweak those parameters, in which case these parameters can be reduced.
The length of time that Linux will wait between a sigterm and a sigkill is controlled by the
TimeoutStopSecparameter in the systemd config file. The default is 90s (seconds).In the tilt environment,
shutdownDelay1is set to zero by default, meaning just shutdown immediately.