Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos with spell checker #3602

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

bodhi-crypo
Copy link
Contributor

  1. fix a bunch of typos with spell checker
  2. Hand-checked to exclude some proprietary writings like Optin

wish can help reduce the overrall typo-related PR

@SEJeff SEJeff added the documentation Improvements or additions to documentation label Dec 14, 2023
Copy link
Collaborator

@SEJeff SEJeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the commit naming guidelines we don't use the google style "chore" , "fix", etc approach.

Just something like docs: fix typos with spell checker.

@bodhi-crypo bodhi-crypo changed the title chore(doc):fix typos with spell checker docs: fix typos with spell checker Dec 14, 2023
@bodhi-crypo
Copy link
Contributor Author

Please see the commit naming guidelines we don't use the google style "chore" , "fix", etc approach.

Just something like docs: fix typos with spell checker.

renamed

@SEJeff
Copy link
Collaborator

SEJeff commented Dec 14, 2023

@bodhi-crypo can you rebase the commit as well? If you're not familiar with how to do an interactive rebase, you can do this from your bodhi-crypo:main branch:

git rebase -i HEAD~2

An editor will pop up and you can find the line that says chore(doc):fix typos with spell checker. At the beginning of that line, change pick to edit. Then run the command:

git commit --amend

And fix the commit message to match the PR title please.

Then you should be able to do:

git rebase --continue

force push your changes and the PR will be updated.

@bodhi-crypo
Copy link
Contributor Author

@bodhi-crypo can you rebase the commit as well? If you're not familiar with how to do an interactive rebase, you can do this from your bodhi-crypo:main branch:

git rebase -i HEAD~2

An editor will pop up and you can find the line that says chore(doc):fix typos with spell checker. At the beginning of that line, change pick to edit. Then run the command:

git commit --amend

And fix the commit message to match the PR title please.

Then you should be able to do:

git rebase --continue

force push your changes and the PR will be updated.

done.learn a lot from you guys.

Copy link
Collaborator

@SEJeff SEJeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much!

@bodhi-crypo
Copy link
Contributor Author

@SEJeff It looks like it could be merged to avoid conflicts with later updates.

Copy link
Contributor

@a5-pickle a5-pickle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing these typos is a great upgarde.

Copy link
Contributor

@nik-suri nik-suri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SEJeff SEJeff merged commit 8b39c1a into wormhole-foundation:main Dec 21, 2023
41 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants