node: Add accepted formats and examples for rpc and ws parameter desc #3622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingyuyap
force-pushed
the
bing/node-parameters-description
branch
2 times, most recently
from
dd63001
to
bc22a93
Compare
|
str.into() conversions are infallible. Using str.try_into().unwrap() would be unnecessary, triggering |
bingyuyap
force-pushed
the
bing/node-parameters-description
branch
from
bc22a93
to
b7b3553
Compare
bingyuyap
changed the base branch from
main
to
bing/rust-linter-unnecessary-fallible-conversions
Base automatically changed from
bing/rust-linter-unnecessary-fallible-conversions
to
main
January 3, 2024 16:39
bingyuyap
force-pushed
the
bing/node-parameters-description
branch
from
b7b3553
to
80622a7
Compare
…ription Signed-off-by: bingyuyap <bingyu.yap.21@gmail.com>
bingyuyap
force-pushed
the
bing/node-parameters-description
branch
from
80622a7
to
616d209
Compare
bingyuyap
requested review from
bruce-riley,
panoel,
kev1n-peters and
evan-gray
as code owners
panoel
reviewed
Jan 3, 2024
panoel
previously approved these changes
Jan 3, 2024
Signed-off-by: bingyuyap <bingyu.yap.21@gmail.com>
bingyuyap
force-pushed
the
bing/node-parameters-description
branch
2 times, most recently
from
be2d73d
to
2ba4570
Compare
Signed-off-by: bingyuyap <bingyu.yap.21@gmail.com>
bingyuyap
force-pushed
the
bing/node-parameters-description
branch
from
2ba4570
to
ec8e38b
Compare
|
Will there be a follow up to this PR? Because I think we should have some verification to enforce that the parameter is the right format (with ws/wss vs. http/https, etc). |
Yes the follow up PR will be addressing this issue to make it fail-fast. |
|
@bruce-riley This is the follow up PR to add verification |
panoel
reviewed
Jan 5, 2024
panoel
approved these changes
Jan 5, 2024
bruce-riley
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #3612