node: Allow tokens to change their symbol in generator script #3968
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to update the governor token list, the script was failing on this check:
It turned out that a token was being classified as "removed" because its symbol had changed. We should allow tokens to change their symbol (like we do on the new token side) so this PR updates the script to only use the chain + address key for removed token lookups; that's a unique identifier after all.
Even if the token symbol included a "-" character this change is safe since we only concat the first 2 elements of the array, and the symbol is the last element in the key strings.