node: devcontainer support #4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-gray
force-pushed
the
node-devcontainer
branch
from
230198c to
d7c50ce
Compare
evan-gray
force-pushed
the
node-devcontainer
branch
from
d7c50ce to
4aa7d79
Compare
evan-gray
force-pushed
the
node-devcontainer
branch
from
4aa7d79 to
f7dcb56
Compare
bruce-riley
approved these changes
Jul 24, 2024
kcsongor
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a devcontainer.json to aid in the development of node / guardian code. While development is currently possible in Linux (including WSL on Windows), providing this container adds an option for non-WSL Windows and ARM (M-series) Mac users which only requires Docker and VS Code. It also shares the same dockerfile used in CI for added assurance of compatibility. Relevant to #4031. Please note, this dockerfile explicitly specifies amd64, which means it will run via qemu or rosetta (depending on your Docker settings) - as far as I understand, the cosmwasm dependency (and possibly others) requires this and there will be a slight performance hit, but it is useable.