Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump foundry to 2024-08-04 nightly #4049

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

evan-gray
Copy link
Contributor

@evan-gray evan-gray commented Jul 31, 2024

We have seen some instances in CI where anvil returns a block number which doesn't match the one queried. Perhaps this issue has been fixed since the nightly currently being used (2024-05-26). Confirmed that the forge output is still the same by exec-ing into the container and running the following before and after the change then diffing the result.

cd ~/app/ethereum/build-forge
find . -type f -exec sha256sum {} \;
cd ~/app/relayer/ethereum/build-forge
find . -type f -exec sha256sum {} \;

kcsongor
kcsongor previously approved these changes Jul 31, 2024
Copy link
Contributor

@kcsongor kcsongor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for checking the build output, other than that this should be a straightforward change

bruce-riley
bruce-riley previously approved these changes Jul 31, 2024
@evan-gray evan-gray marked this pull request as draft July 31, 2024 23:10
@evan-gray
Copy link
Contributor Author

Just hit this error so perhaps the bump does not resolve it, but may be worth considering nonetheless.

@evan-gray
Copy link
Contributor Author

Isolated the bug and reported

@evan-gray evan-gray dismissed stale reviews from bruce-riley and kcsongor via fe4e447 August 4, 2024 15:52
@evan-gray evan-gray changed the title ci: bump foundry to 2024-07-31 nightly ci: bump foundry to 2024-08-04 nightly Aug 4, 2024
@evan-gray
Copy link
Contributor Author

updated to a version which includes the fix and checked the build output again

@evan-gray evan-gray marked this pull request as ready for review August 4, 2024 15:59
@evan-gray evan-gray merged commit c2496cd into wormhole-foundation:main Aug 4, 2024
24 checks passed
@evan-gray evan-gray deleted the bump-foundry branch August 4, 2024 16:29
@evan-gray evan-gray mentioned this pull request Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants