-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: bump foundry to 2024-08-04 nightly #4049
ci: bump foundry to 2024-08-04 nightly #4049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for checking the build output, other than that this should be a straightforward change
Just hit this error so perhaps the bump does not resolve it, but may be worth considering nonetheless. |
Isolated the bug and reported |
updated to a version which includes the fix and checked the build output again |
We have seen some instances in CI where anvil returns a block number which doesn't match the one queried. Perhaps this issue has been fixed since the nightly currently being used (2024-05-26). Confirmed that the forge output is still the same by exec-ing into the container and running the following before and after the change then diffing the result.