Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: Add Makefile test target for arm64 #4057

Merged
merged 2 commits into from
Aug 6, 2024
Merged

node: Add Makefile test target for arm64 #4057

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
606ebfc
node: Add Makefile test target for arm64
johnsaigle Aug 2, 2024
d314600
node: Fix comment in Makefile
johnsaigle Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions node/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
.PHONY test
test:
# Use this command on amd64 systems
go test -v -ldflags '-extldflags "-Wl,--allow-multiple-definition" ' ./...

.PHONY test-arm64
test-arm64:
# Use this command on arm64, otherwise you will encounter linker errors.
# It's not perfect: it will fail due to 'undefined symbols' errors
# for packges using cgo. Still, it will get you farther than running
# the default command.
# To test a single package, use these -ldflags with e.g. ./pkg/governor
go test -ldflags '-extldflags "-Wl,-ld_classic " ' ./...
Loading