Lower governor limits of chains based upon usage

[mdulin2]

I did some analysis of the token bridge for various chains over the course of 90 days. If the governor limit was not close to being reached (lower than maximum usage of 90% within time frame), then they do not need to be as high. Lowering the Governor limit is a good security win for limiting the impact of an exploit.

From my analysis, here is the maximum Governance usage that I found within the 90 day period:

• Aurora (0%)
• Blast (0%)
• Xpla (0%)
• XLayer (0%)
• Mantle (0.90%)
• Acala (2.2%)
• Terra2 (3.6%)
• Near (5.39%)
• Terra (5.54%)
• Karura (7.09%)
• Oasis (9.45%)
• Avalanche (13.62%)
• Polygon (14.64%)

[bruce-riley]

This looks good to me as long as the rest of the security team agrees.

[johnsaigle]

@mdulin2 I'm getting test failures running locally, e.g.:

go test -ldflags '-extldflags "-Wl,-ld_classic " ' ./pkg/governor

--- FAIL: TestChainDailyLimitRange (0.00s)
    --- FAIL: TestChainDailyLimitRange/aurora (0.00s)
        mainnet_chains_test.go:39:
                Error Trace:    /Users/john/coding/wormhole/node/pkg/governor/mainnet_chains_test.go:39
                Error:          "0" is not greater than "0"
                Test:           TestChainDailyLimitRange/aurora
--- FAIL: TestChainListBigTransfers (0.00s)
    mainnet_chains_test.go:66:
                Error Trace:    /Users/john/coding/wormhole/node/pkg/governor/mainnet_chains_test.go:66
                Error:          "0" is not less than "0"
                Test:           TestChainListBigTransfers
    mainnet_chains_test.go:69:
                Error Trace:    /Users/john/coding/wormhole/node/pkg/governor/mainnet_chains_test.go:69
                Error:          "0" is not less than "0"
                Test:           TestChainListBigTransfers
FAIL
FAIL    github.com/certusone/wormhole/node/pkg/governor 0.329s
FAIL

Probably because we've never used a chain limit of 0. It's worth going into these tests and figuring out acceptable modifications for limits of 0.

[mdulin2]

Good catch John. I'll see what the issue is and make some changes.

How do you run all of the tests locally? I always get annoying build errors when I try to run the entire test suite.

[johnsaigle]

@mdulin2 You can use this for unit testing the governor:

cd node/
go test -ldflags '-extldflags "-Wl,-ld_classic " ' ./pkg/governor

See also node/Makefile. I recently committed some info there to help with arm64-based testing as a follow-up to #4031

[mdulin2]

@johnsaigle Tests should be fixed now. @kcsongor says that changing the tests to allow for a limit of 0 seems fine with the new consideration of deprecating chains.