-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node: Governor token list update #4126
node: Governor token list update #4126
Conversation
djb15
commented
Oct 1, 2024
•
edited
Loading
edited
Looks like the Moonbeam USDC price is wrong: https://moonscan.io/address/0x818ec0a7fe18ff94269904fced6ae3dae6d6dc0b We've had this before right? I wonder why the script sees it as being so low.
|
Yeah this happens all the time, check out the funky CoinGecko feed: https://www.coingecko.com/en/coins/multichain-bridged-usdc-moonbeam. I'll adjust manually anyhow |
Hmm on second thought, it looks like this feed has been depegged for a couple of months now and I don't want to have to manually come in and fix this every time. Options:
Imo 2 is the safest (between 1 and 2) assuming the changes to the script doesn't add a bug. And let's assume we did add a bug, the price drop logic that flags price changes in PRs should point this out to us immediately. Thoughts? |
As discussed internally we don't want the Governor to have custom handling to fix up token prices. I've manually fixed the price for now and have reached out to CoinGecko re fixing the discrepancy in that token feed |
1b214f4
to
8dd4415
Compare
8dd4415
to
ef7a0a1
Compare
…ion#4103) The `set -u` options in these scripts caused them to fail with 'unbound variable' errors when CLI args or env variables were unset. This commit fixes the validation so that the scripts output usage info or helpful errors instead of exiting with unbound variable errors that the user must read the source to diagnose. for the script `ethereum/sh/upgrade_all_testnet.sh`, the commit updates a variable name that appears incorrect. node/hack: Print potential USD stablecoins that appear depegged (wormhole-foundation#4130) * node/hack: Print potential USD stablecoins that appear depegged * PR feedback whitepapers: Clarify CCQ sol_pda support (wormhole-foundation#4129) GitHub: Update code owners for go sdk (wormhole-foundation#4133) Deploy Unichain testnet (wormhole-foundation#4134) * Deploy Unichain testnet * Add snaxchain to proto node: Governor token list update (wormhole-foundation#4126) * node: governor token list update * Manually fix token price --------- Co-authored-by: djb15 <djb15@users.noreply.github.com> docs: Update SECURITY.md Replace Guardian Key with abstracted Guardian Signer (wormhole-foundation#4120) * node: add guardiansigner node/pkg * node: replace use of guardian key with guardian signer * node: replace use of vaa.AddSigner with guardian signer * node: add nolint for armor import and fix test * node: handle error returned from signing * apply draft review suggestions * apply pr reviews * apply pr reviews * apply pr reviews * apply pr reviews --------- Co-authored-by: pleasew8t <jason@asymmetric.re> Deploy Worldchain testnet (wormhole-foundation#4140) * Deploy Worldchain testnet * Update WETH address * Fix cli test and add token bridge VAAs add deprecation warning to the top of SDK readme (wormhole-foundation#4142) spy: respect --port if set (wormhole-foundation#4139) codeowners: Update for audits folder (wormhole-foundation#4144) Deploy Monad Devnet (wormhole-foundation#4145) * Deploy Monad Devnet * Code review rework docs: Audit reports (wormhole-foundation#4143) * docs: Audit reports * Rename cosmwasm: add wormchain ibc receiver tests (wormhole-foundation#4121) cosmwasm: add support for json schemas for all contracts (wormhole-foundation#4118) * cosmwasm: add support for json schemas for all contracts * cosmwasm: fixed formatting as per the linter Node: Remove cutover checks (wormhole-foundation#4149) Add interchaintest tests to wormchain