Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: Governor token list update #4126

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

djb15
Copy link
Collaborator

@djb15 djb15 commented Oct 1, 2024

Tokens before = 1534
Tokens after = 1549

Tokens added = 16:
<WH_chain_id>-<WH_token_addr>-<token_symbol>

[
 "1-2ccec8f92e8942182bef15efc347d609a7b2010db68d678664fae043b5f6e707-BOGUS",
 "1-8f286c320f95f37efe6535d91dac27779494093b14e7b427a0a07b1c7f97ccc1-WIT",
 "1-c44051a911b54c7ecffc7ee0b0a40af48b328ae755a99533c8402cb26df43807-MOODENG",
 "2-00000000000000000000000025cbb21a9da7c3c63bb77ccca5b2e2482aedb710-HOBA",
 "2-000000000000000000000000767fe9edc9e0df98e07454847909b5e959d7ca0e-ILV",
 "2-000000000000000000000000f21661d0d1d76d3ecb8e1b9f1c923dbfffae4097-RIO",
 "4-0000000000000000000000002859e4544c4bb03966803b044a93563bd2d0dd4d-SHIB",
 "4-000000000000000000000000352cb5e19b12fc216548a2677bd0fce83bae434b-BTT",
 "4-0000000000000000000000009bf543d8460583ff8a669aae01d9cdbee4defe3c-SKO",
 "4-000000000000000000000000aa88c603d142c371ea0eac8756123c5805edee03-DOG",
 "4-000000000000000000000000bd7b8e4de08d9b01938f7ff2058f110ee1e0e8d4-GHX",
 "5-000000000000000000000000b6a5ae40e79891e4deadad06c8a7ca47396df21c-CBY",
 "10-000000000000000000000000526f1dc408cfe7fc5330ab9f1e78474ceff2a5dd-VEMP",
 "30-0000000000000000000000004158734d47fc9692176b5085e0f52ee0da5d47f1-BAL",
 "30-0000000000000000000000007d49a065d17d6d4a55dc13649901fdbb98b2afba-SUSHI",
 "30-0000000000000000000000009e1028f5f1d5ede59748ffcee5532509976840e0-COMP"
]

Tokens removed = 1:
<WH_chain_id>-<WH_token_addr>-<token_symbol>

[
 "4-0000000000000000000000008db1d28ee0d822367af8d220c0dc7cb6fe9dc442-ETHPAD"
]

Tokens with changed symbols = 0:
<WH_chain_id>-<WH_token_addr>-<old_token_symbol>-><new_token_symbol>

[]

Tokens with invalid symbols = 0:
<WH_chain_id>-<WH_token_addr>-<token_symbol>

[]

Tokens with significant price drops (>50%) = 29:

[
 {
  "token": "1-33660fff0fbce64c4da91c3b3e6e77e58d059df2e05e6c53608de170455ba938-SCT",
  "previousPrice": 0.00732466,
  "newPrice": 0.00129462,
  "percentageChange": "-82.3"
 },
 {
  "token": "1-d6c679aa7652867ebb3221cd90f5cf1d7f1b20e3bfd713c95de54bbdd6df2172-wBIRD",
  "previousPrice": 8.82,
  "newPrice": 3.77,
  "percentageChange": "-57.3"
 },
 {
  "token": "1-eac40dce1cfccb5ca30a878aebb3025763a8d3f0c4f15c3e858b98899982b71f-KSG",
  "previousPrice": 0.00033955,
  "newPrice": 0.00007115,
  "percentageChange": "-79.0"
 },
 {
  "token": "2-00000000000000000000000000e679ba63b509182c349f5614f0a07cdd0ce0c5-DAMEX",
  "previousPrice": 0.00772967,
  "newPrice": 0.0021676,
  "percentageChange": "-72.0"
 },
 {
  "token": "2-0000000000000000000000000316eb71485b0ab14103307bf65a021042c6d380-HBTC",
  "previousPrice": 10676.26,
  "newPrice": 4895.03,
  "percentageChange": "-54.2"
 },
 {
  "token": "2-00000000000000000000000022c5543d1a35178cb03b33f929a959145e538532-WAL",
  "previousPrice": 0.00013836,
  "newPrice": 0.00004576,
  "percentageChange": "-66.9"
 },
 {
  "token": "2-000000000000000000000000255f1b39172f65dc6406b8bee8b08155c45fe1b6-HARAMBE",
  "previousPrice": 8.682e-7,
  "newPrice": 3.44916e-7,
  "percentageChange": "-60.3"
 },
 {
  "token": "2-0000000000000000000000002c8ea636345a231e4b1a28f6eeb2072ed909c406-MemElon",
  "previousPrice": 8.9027e-11,
  "newPrice": 4.3042e-11,
  "percentageChange": "-51.7"
 },
 {
  "token": "2-00000000000000000000000070401dfd142a16dc7031c56e862fc88cb9537ce0-BIRD",
  "previousPrice": 8.82,
  "newPrice": 3.77,
  "percentageChange": "-57.3"
 },
 {
  "token": "2-0000000000000000000000008530b66ca3ddf50e0447eae8ad7ea7d5e62762ed-METADOGE",
  "previousPrice": 1.14032e-10,
  "newPrice": 3.3596e-11,
  "percentageChange": "-70.5"
 },
 {
  "token": "2-000000000000000000000000965b85d4674f64422c4898c8f8083187f02b32c0-SFIL",
  "previousPrice": 2.28,
  "newPrice": 0.064064,
  "percentageChange": "-97.2"
 },
 {
  "token": "2-000000000000000000000000a31b1767e09f842ecfd4bc471fe44f830e3891aa-ROOBEE",
  "previousPrice": 0.00123223,
  "newPrice": 0.00050503,
  "percentageChange": "-59.0"
 },
 {
  "token": "2-000000000000000000000000d6c7bb8531295e88d364ea67d5d1acc7d3f87454-FTR",
  "previousPrice": 0.102296,
  "newPrice": 0.00790626,
  "percentageChange": "-92.3"
 },
 {
  "token": "2-000000000000000000000000e020b01b6fbd83066aa2e8ee0ccd1eb8d9cc70bf-ARCD",
  "previousPrice": 0.03667112,
  "newPrice": 0.01700608,
  "percentageChange": "-53.6"
 },
 {
  "token": "2-000000000000000000000000e831f96a7a1dce1aa2eb760b1e296c6a74caa9d5-NEXM",
  "previousPrice": 0.02758691,
  "newPrice": 0.01185666,
  "percentageChange": "-57.0"
 },
 {
  "token": "4-0000000000000000000000001a131f7b106d58f33eaf0fe5b47db2f2045e5732-DEGEN",
  "previousPrice": 9.18949e-7,
  "newPrice": 7.194e-8,
  "percentageChange": "-92.2"
 },
 {
  "token": "4-00000000000000000000000021f9b5b2626603e3f40bfc13d01afb8c431d382f-ZINU",
  "previousPrice": 2.16515e-10,
  "newPrice": 3.6961e-11,
  "percentageChange": "-82.9"
 },
 {
  "token": "4-0000000000000000000000002a48ece377b87ce941406657b9278b4459595e06-LunaT",
  "previousPrice": 7.41496e-7,
  "newPrice": 2.91312e-7,
  "percentageChange": "-60.7"
 },
 {
  "token": "4-0000000000000000000000008595f9da7b868b1822194faed312235e43007b49-BTT",
  "previousPrice": 0.00146552,
  "newPrice": 0.00070282,
  "percentageChange": "-52.0"
 },
 {
  "token": "4-00000000000000000000000092868a5255c628da08f550a858a802f5351c5223-BRIDGE",
  "previousPrice": 0.00199987,
  "newPrice": 0.00089187,
  "percentageChange": "-55.4"
 },
 {
  "token": "4-0000000000000000000000009767c8e438aa18f550208e6d1fdf5f43541cc2c8-MMIT",
  "previousPrice": 2.7998e-8,
  "newPrice": 1.0773e-8,
  "percentageChange": "-61.5"
 },
 {
  "token": "4-000000000000000000000000bd83010eb60f12112908774998f65761cf9f6f9a-STARS",
  "previousPrice": 0.00019438,
  "newPrice": 0.00007389,
  "percentageChange": "-62.0"
 },
 {
  "token": "5-0000000000000000000000000308a3a9c433256ad7ef24dbef9c49c8cb01300a-GPO",
  "previousPrice": 0.829932,
  "newPrice": 0.04992422,
  "percentageChange": "-94.0"
 },
 {
  "token": "5-000000000000000000000000a7051c5a22d963b81d71c2ba64d46a877fbc1821-EROWAN",
  "previousPrice": 0.00001276,
  "newPrice": 0.00000304,
  "percentageChange": "-76.2"
 },
 {
  "token": "5-000000000000000000000000bc5eb84c052fd012bb902c258c9fd241b17c0005-XNET",
  "previousPrice": 0.121948,
  "newPrice": 0.02817942,
  "percentageChange": "-76.9"
 },
 {
  "token": "24-000000000000000000000000375488f097176507e39b9653b88fdc52cde736bf-TAROT",
  "previousPrice": 0.01077283,
  "newPrice": 0.00444249,
  "percentageChange": "-58.8"
 },
 {
  "token": "30-000000000000000000000000255f1b39172f65dc6406b8bee8b08155c45fe1b6-HARAMBE",
  "previousPrice": 8.682e-7,
  "newPrice": 3.44916e-7,
  "percentageChange": "-60.3"
 },
 {
  "token": "30-00000000000000000000000096e890c6b2501a69cad5dba402bfb871a2a2874c-AAG",
  "previousPrice": 0.00082545,
  "newPrice": 0.00035317,
  "percentageChange": "-57.2"
 }
]

@johnsaigle
Copy link
Contributor

Looks like the Moonbeam USDC price is wrong: https://moonscan.io/address/0x818ec0a7fe18ff94269904fced6ae3dae6d6dc0b

We've had this before right? I wonder why the script sees it as being so low.

 {
  "token": "16-000000000000000000000000818ec0a7fe18ff94269904fced6ae3dae6d6dc0b-USDC",
  "previousPrice": 1,
  "newPrice": 0.091163,
  "percentageChange": "-90.9"
 },

@djb15
Copy link
Collaborator Author

djb15 commented Oct 1, 2024

Looks like the Moonbeam USDC price is wrong: https://moonscan.io/address/0x818ec0a7fe18ff94269904fced6ae3dae6d6dc0b

We've had this before right? I wonder why the script sees it as being so low.

 {
  "token": "16-000000000000000000000000818ec0a7fe18ff94269904fced6ae3dae6d6dc0b-USDC",
  "previousPrice": 1,
  "newPrice": 0.091163,
  "percentageChange": "-90.9"
 },

Yeah this happens all the time, check out the funky CoinGecko feed: https://www.coingecko.com/en/coins/multichain-bridged-usdc-moonbeam.

I'll adjust manually anyhow

@djb15
Copy link
Collaborator Author

djb15 commented Oct 1, 2024

Hmm on second thought, it looks like this feed has been depegged for a couple of months now and I don't want to have to manually come in and fix this every time. Options:

  1. Leave it priced at whatever CoinGecko tells us since it's the source of truth...there could be other tokens like this after all?
  2. Automatically adjust the price of a subset of stablecoins if they appear depegged (in the negative direction). i.e. for USD stablecoins, automatically set the price to 1 if CoinGecko reports <1, but leave otherwise. This has the end effect of having the Governor potentially overpricing tokens, which is much safer than underpricing.
  3. Any other suggestions

Imo 2 is the safest (between 1 and 2) assuming the changes to the script doesn't add a bug. And let's assume we did add a bug, the price drop logic that flags price changes in PRs should point this out to us immediately. Thoughts?

@djb15
Copy link
Collaborator Author

djb15 commented Oct 4, 2024

As discussed internally we don't want the Governor to have custom handling to fix up token prices. I've manually fixed the price for now and have reached out to CoinGecko re fixing the discrepancy in that token feed

@djb15 djb15 force-pushed the node/governor-token-list-update branch from 1b214f4 to 8dd4415 Compare October 4, 2024 23:11
@djb15 djb15 force-pushed the node/governor-token-list-update branch from 8dd4415 to ef7a0a1 Compare October 7, 2024 19:10
@djb15 djb15 merged commit 345a7e4 into wormhole-foundation:main Oct 11, 2024
24 checks passed
@djb15 djb15 deleted the node/governor-token-list-update branch October 11, 2024 20:08
kakucodes pushed a commit to kakucodes/wormhole that referenced this pull request Dec 10, 2024
…ion#4103)

The `set -u` options in these scripts caused them to fail with 'unbound
variable' errors when CLI args or env variables were unset. This commit
fixes the validation so that the scripts output usage info or helpful
errors instead of exiting with unbound variable errors that the user
must read the source to diagnose.

for the script `ethereum/sh/upgrade_all_testnet.sh`, the commit updates
a variable name that appears incorrect.

node/hack: Print potential USD stablecoins that appear depegged (wormhole-foundation#4130)

* node/hack: Print potential USD stablecoins that appear depegged

* PR feedback

whitepapers: Clarify CCQ sol_pda support (wormhole-foundation#4129)

GitHub: Update code owners for go sdk (wormhole-foundation#4133)

Deploy Unichain testnet (wormhole-foundation#4134)

* Deploy Unichain testnet

* Add snaxchain to proto

node: Governor token list update (wormhole-foundation#4126)

* node: governor token list update

* Manually fix token price

---------

Co-authored-by: djb15 <djb15@users.noreply.github.com>

docs: Update SECURITY.md

Replace Guardian Key with abstracted Guardian Signer (wormhole-foundation#4120)

* node: add guardiansigner node/pkg

* node: replace use of guardian key with guardian signer

* node: replace use of vaa.AddSigner with guardian signer

* node: add nolint for armor import and fix test

* node: handle error returned from signing

* apply draft review suggestions

* apply pr reviews

* apply pr reviews

* apply pr reviews

* apply pr reviews

---------

Co-authored-by: pleasew8t <jason@asymmetric.re>

Deploy Worldchain testnet (wormhole-foundation#4140)

* Deploy Worldchain testnet

* Update WETH address

* Fix cli test and add token bridge VAAs

add deprecation warning to the top of SDK readme (wormhole-foundation#4142)

spy: respect --port if set (wormhole-foundation#4139)

codeowners: Update for audits folder (wormhole-foundation#4144)

Deploy Monad Devnet (wormhole-foundation#4145)

* Deploy Monad Devnet

* Code review rework

docs: Audit reports (wormhole-foundation#4143)

* docs: Audit reports

* Rename

cosmwasm: add wormchain ibc receiver tests (wormhole-foundation#4121)

cosmwasm: add support for json schemas for all contracts (wormhole-foundation#4118)

* cosmwasm: add support for json schemas for all contracts

* cosmwasm: fixed formatting as per the linter

Node: Remove cutover checks (wormhole-foundation#4149)

Add interchaintest tests to wormchain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants