Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Update golang #4161

Merged

Conversation

bruce-riley
Copy link
Contributor

@bruce-riley bruce-riley commented Nov 14, 2024

This PR updates the version of golang used by the guardian from 1.21.9 to 1.23.3.

Note: This PR does not update Wormchain / Gateway.

Tested:

  • Node go tests pass
  • Tilt passes
  • Spy works on mainnet
  • Ran in the load testing environment with 19 guardians, generated 1000 VAAs without error

Needed to update the version of golangci-lint to one that works with go 1.23. Then needed to fix a few lint errors that popped up.

To upgrade go, download the linux AMD 64 tarball from here and do the following:

sudo rm -rf /usr/local/go && sudo tar -C /usr/local -xzf ~/Downloads/go1.23.3.linux-amd64.tar.gz

To upgrage golangci-lint do the following:

curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.60.1

@bruce-riley bruce-riley marked this pull request as ready for review November 15, 2024 18:28
@bruce-riley bruce-riley requested a review from pires November 15, 2024 18:29
Copy link
Contributor

@panoel panoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't double check the docker file hash.

Copy link
Collaborator

@pires pires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!

@bruce-riley bruce-riley merged commit 772a715 into wormhole-foundation:main Nov 19, 2024
24 checks passed
@bruce-riley bruce-riley mentioned this pull request Nov 19, 2024
kakucodes added a commit to kakucodes/wormhole that referenced this pull request Dec 10, 2024
author Obie Kaku <obiekaku@gmail.com> 1718989425 -0500
committer Obie Kaku <obiekaku@gmail.com> 1733863492 -0600

chore: refreshed icts

core contract upgrade working

wip

wip

Update wormchain_test.go

fix: creating wormhole ibc channel correctly

debugging ibc handshake

chore: refactoring tests

tests updated

wip

Add interchaintest tests to wormchain

chore: refreshed icts

core contract upgrade working

wip

wip

Update wormchain_test.go

fix: creating wormhole ibc channel correctly

debugging ibc handshake

chore: refactoring tests

tests updated

wip

removed unneeded schema files

revert contract changes

removed unused wasm binaries

reverted unneeded formatting changes

removed unused wasm binaries

Node: p2p.Run not always subscribing to heartbeat channel when it should (wormhole-foundation#4152)

Node: CCQ logging changes (wormhole-foundation#4153)

wormchain: disable ignite

Node: Deploy Worldchain mainnet (wormhole-foundation#4156)

* Node: Deploy Worldchain mainnet

* Code review rework

* node: Governor setup for Worldchain

---------

Co-authored-by: Dirk Brink <hello@dirk.tech>

make: fix VERSION unset if commit has no associated tag

eth: env file for Worldchain Mainnet (wormhole-foundation#4158)

Deploy Ink testnet

Node: Update golang (wormhole-foundation#4161)

* Node: Update golang

* node: Upgrade golangci-lint

Temporarily increasing governor limits for a few chains (wormhole-foundation#4164)

refactoring and clean up

put back the ibc translator update channel chain

remove unused contract upgrade fn

removed wormchaind build

reorganized some test utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants