-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node: Update golang #4161
Merged
bruce-riley
merged 2 commits into
wormhole-foundation:main
from
wormholelabs-xyz:node_update_golang
Nov 19, 2024
Merged
Node: Update golang #4161
bruce-riley
merged 2 commits into
wormhole-foundation:main
from
wormholelabs-xyz:node_update_golang
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
force-pushed
the
node_update_golang
branch
from
November 15, 2024 16:07
8a49662
to
8f2e39b
Compare
bruce-riley
requested review from
evan-gray,
SEJeff,
panoel and
kcsongor
as code owners
November 15, 2024 18:28
johnsaigle
approved these changes
Nov 15, 2024
evan-gray
approved these changes
Nov 16, 2024
panoel
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't double check the docker file hash.
pires
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hooray!
Merged
kakucodes
added a commit
to kakucodes/wormhole
that referenced
this pull request
Dec 10, 2024
author Obie Kaku <obiekaku@gmail.com> 1718989425 -0500 committer Obie Kaku <obiekaku@gmail.com> 1733863492 -0600 chore: refreshed icts core contract upgrade working wip wip Update wormchain_test.go fix: creating wormhole ibc channel correctly debugging ibc handshake chore: refactoring tests tests updated wip Add interchaintest tests to wormchain chore: refreshed icts core contract upgrade working wip wip Update wormchain_test.go fix: creating wormhole ibc channel correctly debugging ibc handshake chore: refactoring tests tests updated wip removed unneeded schema files revert contract changes removed unused wasm binaries reverted unneeded formatting changes removed unused wasm binaries Node: p2p.Run not always subscribing to heartbeat channel when it should (wormhole-foundation#4152) Node: CCQ logging changes (wormhole-foundation#4153) wormchain: disable ignite Node: Deploy Worldchain mainnet (wormhole-foundation#4156) * Node: Deploy Worldchain mainnet * Code review rework * node: Governor setup for Worldchain --------- Co-authored-by: Dirk Brink <hello@dirk.tech> make: fix VERSION unset if commit has no associated tag eth: env file for Worldchain Mainnet (wormhole-foundation#4158) Deploy Ink testnet Node: Update golang (wormhole-foundation#4161) * Node: Update golang * node: Upgrade golangci-lint Temporarily increasing governor limits for a few chains (wormhole-foundation#4164) refactoring and clean up put back the ibc translator update channel chain remove unused contract upgrade fn removed wormchaind build reorganized some test utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the version of golang used by the guardian from
1.21.9
to1.23.3
.Note: This PR does not update Wormchain / Gateway.
Tested:
Needed to update the version of golangci-lint to one that works with go 1.23. Then needed to fix a few lint errors that popped up.
To upgrade go, download the linux AMD 64 tarball from here and do the following:
sudo rm -rf /usr/local/go && sudo tar -C /usr/local -xzf ~/Downloads/go1.23.3.linux-amd64.tar.gz
To upgrage golangci-lint do the following:
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.60.1