feat: mainnet validator hot swaps #4203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelsmith-2019
requested review from
nik-suri,
johnsaigle,
mdulin2 and
evan-gray
as code owners
nik-suri
reviewed
Dec 19, 2024
| @@ -50,16 +51,6 @@ func (k msgServer) RegisterAccountAsGuardian(goCtx context.Context, msg *types.M | |||
| return nil, types.ErrGuardianSetNotFound | |||
| } | |||
|
|
|||
| consensusGuardianSetIndex, consensusIndexFound := k.GetConsensusGuardianSetIndex(ctx) | |||
There was a problem hiding this comment.
will removing this change the amount of gas that's used for the transaction? That could lead to consensus errors. If so we could gate this functionality behind a block height.
There was a problem hiding this comment.
I'm unsure of that. We could still keep the check in to verify an existing consensus guardian set index exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows mainnet validator hot swapping. Previously, only single validator clusters allowed hot swapping for testnet purposes. This PR removes that check and introduces an integration test which validates the process of swapping an existing guardian's validator to a new validator and then back again.